Fixed proxy support leading to false positives#56
Closed
slicingmelon wants to merge 1 commit intolaluka:mainfrom
slicingmelon:fix-proxy-support
Closed
Fixed proxy support leading to false positives#56slicingmelon wants to merge 1 commit intolaluka:mainfrom slicingmelon:fix-proxy-support
slicingmelon wants to merge 1 commit intolaluka:mainfrom
slicingmelon:fix-proxy-support
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current proxy support implementation does not work well, it leads only to false positives. (e.g. all responses are 200 OK) because it does not handle all HTTP methods properly.
Sample results before the fix
Sample results after the patch: